Skip to content

Remove cypress from shell dependencies#17829

Merged
rak-phillip merged 1 commit into
rancher:masterfrom
rak-phillip:task/cypress-shell-deps
May 27, 2026
Merged

Remove cypress from shell dependencies#17829
rak-phillip merged 1 commit into
rancher:masterfrom
rak-phillip:task/cypress-shell-deps

Conversation

@rak-phillip
Copy link
Copy Markdown
Member

@rak-phillip rak-phillip commented May 26, 2026

Summary

This removes cypress as a direct dependency of Rancher Shell.

fixes #17622

Occurred changes and/or fixed issues

  • Remove cypress from shell dependencies

Technical notes summary

I don't see a need for cypress to be included as a runtime dependency of shell after reviewing the Dashboard repo. Any project that consumes @rancher/shell currently inherits cypress as a transitive runtime dependency, including projects that have no need for it. Consumers that require cypress or any other E2E test framework for their own test suite should declare it explicitly in their own devDependencies.

Areas or cases that should be tested

Existing e2e functions should still function as they did before.

CI gates should pass.

Areas which could experience regressions

Any consumers of shell that rely on cypress as a transitive dependency will need to declare cypress as their own dev dependency. One might argue that @rancher/cypress can be used instead1.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Footnotes

  1. https://www.npmjs.com/package/@rancher/cypress?activeTab=readme

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip force-pushed the task/cypress-shell-deps branch from f787756 to 11124b4 Compare May 26, 2026 20:40
@rak-phillip rak-phillip requested a review from aalves08 May 26, 2026 21:16
@rak-phillip rak-phillip added this to the v2.15.0 milestone May 26, 2026
@rak-phillip rak-phillip marked this pull request as ready for review May 26, 2026 21:56
@rak-phillip rak-phillip self-assigned this May 26, 2026
Copy link
Copy Markdown
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remind myself this is the shell package and not the top-level one!

Copy link
Copy Markdown
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit ee5b2f8 into rancher:master May 27, 2026
131 of 139 checks passed
@rak-phillip rak-phillip deleted the task/cypress-shell-deps branch May 27, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused and misplaced dependencies

3 participants